Remove fast-uuid as a dependency#1140
Merged
Merged
Conversation
Contributor
|
https://bugs.openjdk.org/browse/JDK-8196334 TIL. Very impressive. 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's time to drop
fast-uuidas a dependency. It's been integrated into the JDK (hooray!) for a while, and now the stockUUIDserializers/parsers are at least as fast as whatfast-uuidcould do. There's still some benefit to usingfast-uuidfor folks stuck on older JDK versions, but I think almost everybody has moved on at this point, and more people will benefit from removingfast-uuidthan from keeping it.